Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make database secrets more consistent #2889

Open
corneliusroemer opened this issue Sep 27, 2024 · 1 comment
Open

Make database secrets more consistent #2889

corneliusroemer opened this issue Sep 27, 2024 · 1 comment
Labels
config Configuration related issues, i.e. helm processing refactoring Code requires refactoring

Comments

@corneliusroemer
Copy link
Contributor

@anna-parker and I were looking into how to get the database name from the config. We were a bit confused that we currently specify secrets for keycloak-database and loculus-database in inconsistent ways:

  database:
    type: sealedsecret
    clusterWide: "true"
    encryptedData:
      host: AgDUG
      password: AgCm
      url: AgC
      username: AgAp
  keycloak-database:
    type: sealedsecret
    clusterWide: "true"
    encryptedData:
      addr: AgAw
      database: AgB
      password: AgDB
      port: Ag
      username: AgAuZZ

For more consistency we should

  • rename database to loculus-database
  • use identical fields in encrypted data, i.e. also have database, addr, url ... in loculus-database and vice versa
@corneliusroemer corneliusroemer added refactoring Code requires refactoring config Configuration related issues, i.e. helm processing labels Sep 27, 2024
@theosanderson
Copy link
Member

I wouldn't add unused fields: it's already a fair bit of effort to seal all the secrets. That doesn't stop you getting consistency, I expect, but it means you need to construct the URL from the address and the port, for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration related issues, i.e. helm processing refactoring Code requires refactoring
Projects
None yet
Development

No branches or pull requests

2 participants