Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: document what happens to missing keys and empty fields in extract-unprocessed-data #2919

Open
corneliusroemer opened this issue Oct 1, 2024 · 3 comments

Comments

@corneliusroemer
Copy link
Contributor

description = "The key is the segment name, the value is the nucleotide sequence",

corneliusroemer added a commit that referenced this issue Oct 1, 2024
(cherry picked from commit 83093a10383415bd7e3f75e84158160596c13a98)
@corneliusroemer
Copy link
Contributor Author

Per the prepro specs it should never be null - so we should test that empty fields are indeed returned as "" rather than null

@chaoran-chen
Copy link
Member

I believe that it should never by null or "" but instead mapped to main. And that's just "internally" within Loculus/LAPIS/pipeline but won't be ever exposed to the end user. For the pipeline, the use of main is documented here (but maybe too briefly).

@corneliusroemer
Copy link
Contributor Author

Ah sorry I referenced the wrong column, we were wondering about the metadata value type - the spec is good, but swagger should have the same info and is currently not quite as explicit as it could be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants