Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAPIS readiness probe should return ready even on empty database #2941

Closed
corneliusroemer opened this issue Oct 3, 2024 · 2 comments
Closed
Labels
bug Something isn't working deployment Code changes targetting the deployment infrastructure silo/LAPIS upstream silo/LAPIS issue

Comments

@corneliusroemer
Copy link
Contributor

It seems that the LAPIS readiness probe fails if the database is empty. We should use a readiness probe that works for an empty database.

Maybe #2934 can help here? @fengelniederhammer

image
@corneliusroemer corneliusroemer added bug Something isn't working deployment Code changes targetting the deployment infrastructure silo/LAPIS upstream silo/LAPIS issue labels Oct 3, 2024
@theosanderson
Copy link
Member

Are you sure? I thought we addressed that. We have lots of instances that show 0 results.

@corneliusroemer
Copy link
Contributor Author

Hmm, it's possible I'm wrong here - I had definitely forgotten to start the backend, so that might have contributed, though it's odd that LAPIS showed not ready in that case instead of SILO preprocessing.

All I know is that LAPIS was showing not ready for a long time in k9s, while the backend was not up. Let's see.

@corneliusroemer corneliusroemer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment Code changes targetting the deployment infrastructure silo/LAPIS upstream silo/LAPIS issue
Projects
None yet
Development

No branches or pull requests

2 participants