Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse/search page navigations are not added to the browser history #2942

Open
chaoran-chen opened this issue Oct 3, 2024 · 3 comments
Open
Labels
bug Something isn't working website Tasks related to the web application

Comments

@chaoran-chen
Copy link
Member

At the moment, if we go to the browse page and perform searches, navigate between result pages and open entries as modal, it changes the URL but it does not add new entries to the browser history. The implication is that if you go back a page, you will leave the page entirely.

Screen.Recording.2024-10-03.at.13.43.21.mov

I think that the correct behavior should be that every change of URL gets pushed to the browser history.

@chaoran-chen chaoran-chen added bug Something isn't working website Tasks related to the web application labels Oct 3, 2024
@theosanderson
Copy link
Member

My opinion on ideal behaviour would be

  • pagination adds to history [this is a discrete event]
  • changing search filters does not add to history [not a discrete event]
  • (no strong feelings on modal opening - which isn't yet in the URL, but we should add - but happy for that to be in history)

@chaoran-chen
Copy link
Member Author

chaoran-chen commented Oct 3, 2024

I can see that it is a bit difficult with the search filters because if a user adds multiple filters, we don't know whether they consider it as multiple searches or just one search but I'd personally rather add a bit more to the history than not enough as missing something in the history would be losing information. For me (and this might because I have a mouse with back and forward buttons), having to go back multiple pages is less annoying then loosing a page from a history. E.g., if I enter a lot filters to search something and then delete a few, I would want to have the option to go back and see the previous search and not have to enter all the filters again.

We could maybe check out how related pages do that. I tried out Zalando but they actually have a big bug:

Screen.Recording.2024-10-03.at.14.03.09.mov

@theosanderson
Copy link
Member

I definitely have had the experience of getting frustrated at having too much in the history. (Mainly on my own sites I was developing, I think). But yeah, opinions will differ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website Tasks related to the web application
Projects
Status: No status
Development

No branches or pull requests

2 participants