Refactor - replace list with deque: TaskSet._task_queue & WindowsKeyPoller.captured_chars #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Irrelevant for real performance. Not technically worse than the current implementation but not significantly better either. |
|
I’m sorry, I got confused by your changes in input_events. They are not really relevant for performance, but your changes in TaskSet really were, and I should have accepted this PR. If you want to make a new PR for input events I will accept it. |
|
No problem. Thanks for the response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskSet._task_queue & WindowsKeyPoller.captured_chars use methods responsible for removing/appending elements at beginning & end.
collections.deque performs those in constant time in contrast with list (linear time for appending/removing at beginning).