Update TaskSet to use deque #2667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, so I tried the test |
|
Did you figure it out? |
Not yet, spinning up a new branch and messing with the tests, it’s weird cause the tests are failing even on a non altered master branch, for some reason the workers just don’t connect and it times our. |
|
👍 let me know if you need help. |
|
@Hchanni I tweaked your solution a little and made a new PR. Thanks for the inspiration :) |
|
Oh shoot thanks for getting the fix out @cyberw got wrapped up with some locust stuff at work haha and didn't get a chance to actually dig into it. I'll take a look at the PR I'm actually curious to see why mine was failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw a comment in Issue #2653 and thought I'd give it a try, just updates the insertion to the first element to use
appendleftand also updates the type of_task_queueto use the collections deque.