New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite weight by config user before environment weight validation #2971

Open

tdadela wants to merge 3 commits into locustio:master from tdadela:overwrite-weight-by-config-user-before-environment-weight-validation

Contributor

tdadela commented Nov 7, 2024

Current order:

Removing user classes with weight zero. (_remove_user_classes_with_weight_zero()).
Overwriting weights of user classes by CL config.

New order:

Overwriting weights of user classes by CL config.
Removing user classes with weight zero. (_remove_user_classes_with_weight_zero()).

Related to: #2852.

tdadela added 3 commits

November 7, 2024 00:20


          fix: overwrite user weight by CL config before removing user classes …

34d8f57

…with weight zero


          Merge remote-tracking branch 'origin' into overwrite-weight-by-config…

e082ee6

…-user-before-environment-weight-validation


          fix: check if override_user_weights is empty or None

bbf8b01

Collaborator

cyberw commented Nov 24, 2024

Looks ok. Can you add some sort of test case that shows why this was needed/what benefit it provides?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet