Improved PRO label drawing, and fixed a display bug #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PRO label is now applied to the `::after` pseudo-selector of the actual `.pro` element. This is to prevent a collision with Docusaurus' own `::after`, which draws the submenus generally. This affects the way that the PRO label is positioned (added comments for future generations). Additionally, I have implemented some changes for a more consistent look for the PRO tags across different sections (though, some small and mysterious quirks of style do remain)
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you @adiron. I'm still not seeing the
https://deploy-preview-447--vcluster-docs-site.netlify.app/docs/vcluster/next/integrations/kubevirt/ |
|
I was very focused on the style issue and missed that bit. Interestingly, here it looks like the |
The folders were somehow interfering and not allowing the CSS to be applied correctly, which meant that the PRO label was not showing for these PRO features.
|
Pulled Kubevirt and Cert Manager out of their folders which fixed the classes not being applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PRO label is now applied to the
::afterpseudo-selector of the actual.proelement. This is to prevent a collision with Docusaurus' own::after, which draws the submenus generally.This affects the way that the PRO label is positioned (added comments for future generations).
Additionally, I have implemented some changes for a more consistent look for the PRO tags across different sections (though, some small and mysterious quirks of style do remain)
Content Description
Preview Link
Internal Reference
Closes DOC-397
Screenshots
Support for collapsible pro items (none currently exist, this is a test):
Other pro tags:
