-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From host sync docs with examples #458
Conversation
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
✅ Deploy Preview for vcluster-docs-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
vale
vcluster/_fragments/sync-from-host-secret-example.mdx|80 col 78| [Google.FirstPerson] Avoid first-person pronouns such as 'my'.
vcluster/_fragments/sync-from-host-secret-example.mdx|83 col 5| [Google.We] Try to avoid using first-person plural like 'Let's'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|12 col 21| [Google.WordList] Use 'turn off' or 'off' instead of 'disabled'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|15 col 10| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|18 col 15| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|24 col 88| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|24 col 157| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|26 col 22| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|28 col 35| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|30 col 91| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|57 col 45| [Google.OptionalPlurals] Don't use plurals in parentheses such as in 'namespace(s)'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|73 col 200| [Loft.no-vcluster-platform] Prefer using 'the platform' instead of 'vCluster Platform'
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|87 col 25| [Google.OptionalPlurals] Don't use plurals in parentheses such as in 'map(s)'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|123 col 6| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|144 col 65| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/configmaps.mdx|145 col 173| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|12 col 21| [Google.WordList] Use 'turn off' or 'off' instead of 'disabled'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|15 col 10| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|18 col 15| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|24 col 88| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|24 col 157| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|26 col 22| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|30 col 88| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|32 col 35| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|54 col 41| [Google.OptionalPlurals] Don't use plurals in parentheses such as in 'namespace(s)'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|71 col 197| [Loft.no-vcluster-platform] Prefer using 'the platform' instead of 'vCluster Platform'
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|86 col 18| [Google.OptionalPlurals] Don't use plurals in parentheses such as in 'secret(s)'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|122 col 6| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|143 col 62| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|144 col 173| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|15 col 102| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|15 col 194| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|19 col 10| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|22 col 4| [Google.Headings] 'Cluster Scope Example' should use sentence-style capitalization.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|34 col 4| [Google.Headings] 'Namespaced Scope CRDs' should use sentence-style capitalization.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|35 col 21| [Google.WordList] Use 'turn off' or 'off' instead of 'disabled'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|37 col 15| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|43 col 88| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|43 col 157| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|45 col 22| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|55 col 10| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|60 col 35| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|62 col 97| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|64 col 1| [Google.We] Try to avoid using first-person plural like 'We'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|64 col 4| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|64 col 66| [Google.We] Try to avoid using first-person plural like 'our'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|98 col 205| [Loft.no-vcluster-platform] Prefer using 'the platform' instead of 'vCluster Platform'
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|146 col 5| [Google.Headings] 'Pro Patches' should use sentence-style capitalization.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|150 col 6| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|173 col 70| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|174 col 173| [Google.Will] Avoid using 'will'.
Signed-off-by: Paweł Bojanowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
vale
vcluster/configure/vcluster-yaml/sync/from-host/secrets.mdx|144 col 173| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|15 col 102| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|15 col 194| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|19 col 10| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|22 col 4| [Google.Headings] 'Cluster Scope Example' should use sentence-style capitalization.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|34 col 4| [Google.Headings] 'Namespaced Scope CRDs' should use sentence-style capitalization.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|35 col 21| [Google.WordList] Use 'turn off' or 'off' instead of 'disabled'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|37 col 15| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|43 col 88| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|43 col 157| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|45 col 22| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|55 col 10| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|60 col 35| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|62 col 97| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|64 col 1| [Google.We] Try to avoid using first-person plural like 'We'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|64 col 4| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|64 col 66| [Google.We] Try to avoid using first-person plural like 'our'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|98 col 205| [Loft.no-vcluster-platform] Prefer using 'the platform' instead of 'vCluster Platform'
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|146 col 5| [Google.Headings] 'Pro Patches' should use sentence-style capitalization.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|150 col 6| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|173 col 70| [Google.Will] Avoid using 'will'.
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx|174 col 173| [Google.Will] Avoid using 'will'.
vcluster/_fragments/sync-from-host-namespaced-custom-resources-example.mdx
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits.
vcluster/_fragments/sync-from-host-namespaced-custom-resources-example.mdx
Show resolved
Hide resolved
Signed-off-by: Paweł Bojanowski <[email protected]>
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx
Outdated
Show resolved
Hide resolved
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx
Outdated
Show resolved
Hide resolved
…ple at the top, bullet point list of assumptions Signed-off-by: Paweł Bojanowski <[email protected]>
vcluster/configure/vcluster-yaml/sync/from-host/custom-resources.mdx
Outdated
Show resolved
Hide resolved
Signed-off-by: Paweł Bojanowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pr @hidalgopl , added some suggestions and comments. Key takeaways:
vCluster
vs virtual cluster. We refer tovirtrual cluster
for everyting that is running as a cluster and to vCluster as the mechanism enabling it.- I've reviewed the secrets.mdx since configmaps.mdx isa copy of it, so all comments apply there too.
Signed-off-by: Paweł Bojanowski <[email protected]>
Signed-off-by: Paweł Bojanowski <[email protected]>
There are a few small style tweaks, but I don't want to block the PR and will do it later. Thanks @hidalgopl ! |
Content Description
Preview Link
Internal Reference
Closes DOC-401