Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enterprise pricing admonitions #468

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: enterprise pricing admonitions #468

wants to merge 2 commits into from
+63 −2

Conversation

Piotr1215
Copy link
Contributor

Content Description

  • rename sidebar pro label to enterprise
  • introduce custom enterprise admonitions

The admonitions can be referenced as separate partials on any page. Will be versioned with vcluster versions.

Preview Link

N/A

Internal Reference

Closes DOC-452

@Piotr1215 Piotr1215 requested a review from joaniekube February 24, 2025 13:13
@netlify Netlify
Copy link

netlify bot commented Feb 24, 2025 •
edited
Loading

✅ Deploy Preview for vcluster-docs-site ready!

Name Link
🔨 Latest commit 630edbc
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/67bc70572729f0000883cbc8
😎 Deploy Preview https://deploy-preview-468--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Piotr1215 Piotr1215 requested a review from adiron February 24, 2025 13:13
adiron
adiron approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@adiron adiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a lot useful to say about the code per se. Looks good, works well (I tested the admonition as well and it renders fine as far as I can tell).

joaniekube
joaniekube reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion, but up to you if you would like to incorporate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaniekube joaniekube joaniekube left review comments

@zerbitx zerbitx zerbitx approved these changes

@adiron adiron adiron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Piotr1215 @zerbitx @adiron @joaniekube