[tests] fix tests running under ASAN and compiler warnings

loganek · May 5, 2018 · f8a2491 · f8a2491
1 parent 8009416
commit f8a2491
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/tests/lib/test_task_scheduler.cpp b/tests/lib/test_task_scheduler.cpp
@@ -20,7 +20,7 @@ class TestTaskScheduler : public ::testing::Test
         ht_task_scheduler_init(&_scheduler);
     }
 
-    void TearDown()
+    void TearDown() override
     {
         ht_task_scheduler_deinit(&_scheduler);
     }

diff --git a/tests/lib/test_timeline.cpp b/tests/lib/test_timeline.cpp
@@ -141,7 +141,7 @@ TEST_F(TestTimeline, ThreadSafeMessageShouldWorkWithMultipleThreads)
     ht_timeline_register_listener(&timeline, test_listener<HT_Event>, &info);
 
     // Act
-    std::thread th = std::thread([&timeline, event_count] {
+    std::thread th = std::thread([&timeline] {
         for (size_t i = event_count / 2; i < event_count; i++)
         {
             HT_DECL_EVENT(HT_Event, event);

diff --git a/tests/parser/test_event.cpp b/tests/parser/test_event.cpp
@@ -38,10 +38,10 @@ TEST_F(TestEvent, ValidateSetValueMethod)
 TEST_F(TestEvent, SetTimestampValueShouldUpdateTimestampField)
 {
    // Arrange
+    auto timestamp_field = std::make_shared<EventKlassField>("timestamp", "field_type", FieldTypeId::UINT64);
     Event event(_klass);
     FieldType value{};
     value.f_UINT64 = 987;
-    auto timestamp_field = std::make_shared<EventKlassField>("timestamp", "field_type", FieldTypeId::UINT64);
 
     // Act
     event.set_value(timestamp_field.get(), value);
@@ -128,8 +128,8 @@ TEST_F(TestEvent, CopyEventWithNullStringShouldSetFieldValueToNull)
 TEST_F(TestEvent, CopyEventWithNullEventShouldSetFieldValueToNull)
 {
     // Arrange
-    Event event(_klass);
     auto field = std::make_shared<EventKlassField>("base_field3", "klass_name", FieldTypeId::STRUCT);
+    Event event(_klass);
     event.set_value<Event*>(field.get(), nullptr);
 
     // Act