Address reviewer comments idaholab#29484

loganharbour · Oct 24, 2024 · ef18742 · ef18742
1 parent 8cf21f9
commit ef18742
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 1 deletion.
diff --git a/modules/subchannel/doc/content/source/ics/FCTFdisplacementIC.md b/modules/subchannel/doc/content/source/ics/FCTFdisplacementIC.md
@@ -8,6 +8,21 @@
 
 This is a custom, hard coded kernel, that calculates the deformation of the duct (`displacement` [AuxVariable](https://mooseframework.inl.gov/syntax/AuxVariables/index.html)) for the [AREVA FCTF](https://www.osti.gov/servlets/purl/1346027/).
 
+## Example Input File Syntax
+
+An example input file that uses this initial condition kernel is shown below:
+
+!listing /examples/areva_FCTF/FCTF_deformed.i language=cpp
+
+In this input file the variable `displacement` is populated in the Initial Conditions block (ICs), using the custom kernel `FCTFdisplacementIC`
+
+!listing /examples/areva_FCTF/FCTF_deformed.i block=ICs language=cpp
+
+SCM models the effect of the deformation of the duct by adapting the geometric parameters of the perimetric subchannels according to a representative per subchannel deformation variable,
+which is called Displacement (`displacement` D). This variable is calculated based on the centroid coordinates of each subchannel.  [!cite](KYRIAKOPOULOS2024113562).
+
+If the
+
 !syntax parameters /ICs/FCTFdisplacementIC
 
 !syntax inputs /ICs/FCTFdisplacementIC

diff --git a/modules/subchannel/doc/content/source/ics/ics.bib b/modules/subchannel/doc/content/source/ics/ics.bib
@@ -0,0 +1,13 @@
+@article{KYRIAKOPOULOS2024113562,
+title = {Validation of MOOSE’s subchannel module using the AREVA FCTF heated bundle benchmark},
+journal = {Nuclear Engineering and Design},
+volume = {428},
+pages = {113562},
+year = {2024},
+issn = {0029-5493},
+doi = {https://doi.org/10.1016/j.nucengdes.2024.113562},
+url = {https://www.sciencedirect.com/science/article/pii/S0029549324006629},
+author = {Vasileios Kyriakopoulos and Mauricio Tano Retamales},
+keywords = {Subchannel, MOOSE, SFR, LMFBR},
+abstract = {The SubChannel Module, referred to as SCM henceforward in this document, is a subchannel code within the Multiphysics Object-Oriented Simulation Environment (MOOSE) developed at the Idaho National Laboratory (INL). SCM, is able to model flow through liquid-metal cooled, wire-wrapped fuel pin sub-assemblies, ordered in a triangular lattice. This work extends the existing validation done for these flow types and geometries and introduces validation for the newly implemented capability to model flows within a deformed duct. The subchannel duct deformation modeling approach consisted of reproducing the deformed duct effect on the geometric parameters of the boundary subchannels, i.e., modifying surface area, wetted perimeter and pin to duct gap. Then, the model was validated using experimental data taken from Areva’s fuel cooling test facility (FCTF).}
+}
diff --git a/modules/subchannel/examples/EBR-II/3d_SC_ss.i b/modules/subchannel/examples/EBR-II/3d_SC_ss.i
@@ -68,6 +68,9 @@ unheated_length_exit = '${fparse 26.9*scale_factor}'
   [w_perim]
     block = subchannel
   []
+  [displacement]
+    block = subchannel
+  []
   [q_prime]
     block = fuel_pins
   []

diff --git a/modules/subchannel/examples/EBR-II/Pr_SC_ss.i b/modules/subchannel/examples/EBR-II/Pr_SC_ss.i
@@ -521,7 +521,7 @@ ramp_time = 1.0
 
 [AuxKernels]
   [QPrime]
-    type = QPrimeDuctFVAux
+    type = QPrimeDuctAux
     diffusivity = ${k_wrapper}
     flat_to_flat = ${flat_to_flat}
     variable = q_prime_duct

diff --git a/modules/subchannel/examples/EBR-II/XX09_SC_SS.i b/modules/subchannel/examples/EBR-II/XX09_SC_SS.i
@@ -115,6 +115,9 @@ unheated_length_exit = '${fparse 26.9*scale_factor}'
   [mu]
     block = subchannel
   []
+  [displacement]
+    block = subchannel
+  []
   [q_prime]
     block = fuel_pins
   []