new code block with error handling LOG-9481 #29
Conversation
README.md
Outdated
| trace_id: '163e169e-a326-4b1b-a8f5-7169dd4eeca8', | ||
| } | ||
| logger.log({ | ||
| message: JSON.stringify(log_obj_info), // Optional. If not provided, the stringified (read JSON) object in it's entirety will be sent as the payload |
There was a problem hiding this comment.
| message: JSON.stringify(log_obj_info), // Optional. If not provided, the stringified (read JSON) object in it's entirety will be sent as the payload | |
| message: JSON.stringify(log_obj_info), // Optional. If not provided, the stringified (read JSON) object in its entirety will be sent as the payload |
There was a problem hiding this comment.
Gracious thank you for catching that. I literally just swapped out the code block and didn't look at rest of doc.
Co-authored-by: Darin Spivey <[email protected]>
Co-authored-by: Darin Spivey <[email protected]>
|
What happened to the other change? There's only 1 now. Did you force push over it, @tanberry ? |
Merge branch 'log-9481' of github.com:logdna/logdna-winston into log-9481
|
Sorry about that @darinspivey; I attempted to use the "Commit suggestion" button on the UI for both of your edits, and I don't think it worked for one of them. SoI made the changes locally and pushed again. No for sure I don't force push anything, not that confident in here yet. :-) |
|
Ah, I just saw in the Jira the new/updated code chunk. OK, will add that in next. |
|
hey @darinspivey, i changed it last minute on Tana and caused some confusion 🤦. What's in the Jira now has the correct modifications. Changed ordering, comments, a little structure and added a warn example |
|
okeeeee now this PR has the latest code block, the whole thing, in it, and is ready for review/approval/merging. ;-) |
Per Jira LOG-9481, Braxton reworked code example to include error handling best practice.