Skip to content

Commit

Permalink
Create aliases for variable_api
Browse files Browse the repository at this point in the history
  • Loading branch information
aversey committed Jul 17, 2024
1 parent de2b4c8 commit 93b838f
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 64 deletions.
24 changes: 24 additions & 0 deletions python/hopsworks/core/variable_api.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#
# Copyright 2024 Hopsworks AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

from hopsworks_common.core.variable_api import (
VariableApi,
)


__all__ = [
VariableApi,
]
1 change: 0 additions & 1 deletion python/hopsworks_common/client/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# limitations under the License.
#


from __future__ import annotations

from enum import Enum
Expand Down
5 changes: 3 additions & 2 deletions python/hopsworks_common/core/variable_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#

from __future__ import annotations

import re
from typing import Optional, Tuple

from hopsworks import client
from hopsworks.client.exceptions import RestAPIError
from hopsworks_common import client
from hopsworks_common.client.exceptions import RestAPIError


class VariableApi:
Expand Down
68 changes: 7 additions & 61 deletions python/hsfs/core/variable_api.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright 2022 Hopsworks AB
# Copyright 2024 Hopsworks AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -13,66 +13,12 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
from __future__ import annotations

import re
from hopsworks_common.core.variable_api import (
VariableApi,
)

from hsfs import client
from hsfs.client.exceptions import RestAPIError


class VariableApi:
def get_version(self, software: str):
_client = client.get_instance()
path_params = [
"variables",
"versions",
]

resp = _client._send_request("GET", path_params)
for entry in resp:
if entry["software"] == software:
return entry["version"]
return None

def parse_major_and_minor(self, backend_version):
version_pattern = r"(\d+)\.(\d+)"
matches = re.match(version_pattern, backend_version)

return matches.group(1), matches.group(2)

def get_flyingduck_enabled(self):
_client = client.get_instance()
path_params = [
"variables",
"enable_flyingduck",
]

resp = _client._send_request("GET", path_params)
return resp["successMessage"] == "true"

def get_loadbalancer_external_domain(self):
_client = client.get_instance()
path_params = [
"variables",
"loadbalancer_external_domain",
]

try:
resp = _client._send_request("GET", path_params)
return resp["successMessage"]
except RestAPIError:
return ""

def get_service_discovery_domain(self):
_client = client.get_instance()
path_params = [
"variables",
"service_discovery_domain",
]

try:
resp = _client._send_request("GET", path_params)
return resp["successMessage"]
except RestAPIError:
return ""
__all__ = [
VariableApi,
]

0 comments on commit 93b838f

Please sign in to comment.