Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1439][APPEND] Apply ruff formatting and fixes to the merged repo #232

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Jul 17, 2024

JIRA Issue: FSTORE-1439

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey requested a review from kennethmhc July 17, 2024 12:43
@aversey aversey merged commit a612df1 into logicalclocks:main Jul 17, 2024
13 checks passed
aversey added a commit to aversey/hopsworks-api that referenced this pull request Jul 18, 2024
…epo (logicalclocks#232)

* Ruff fix

* Ruff format

* Ruff fix

* Revert making hsfs/client/base proper abstract class
aversey added a commit to aversey/hopsworks-api that referenced this pull request Jul 18, 2024
…epo (logicalclocks#232)

* Ruff fix

* Ruff format

* Ruff fix

* Revert making hsfs/client/base proper abstract class
aversey added a commit to aversey/hopsworks-api that referenced this pull request Jul 18, 2024
…epo (logicalclocks#232)

* Ruff fix

* Ruff format

* Ruff fix

* Revert making hsfs/client/base proper abstract class
kennethmhc added a commit to kennethmhc/hopsworks-api that referenced this pull request Jul 19, 2024
kennethmhc added a commit that referenced this pull request Jul 19, 2024
* Revert "[FSTORE-1453] Move client, decorators, variable_api and constants to hopsworks_common (#229)"

This reverts commit 85deafd.

* Revert "[FSTORE-1439][APPEND] Apply ruff formatting and fixes to the merged repo (#232)"

This reverts commit a612df1.

* Revert "[FSTORE-1439] Merge hopsworks-api, feature-store-api and machine-learning-api"

This reverts commit 67484a9.

* Revert "[FSTORE-1454] Unify variable_api and project_api (#219)"

This reverts commit dd4470a.

* Revert "Merge machine-learning-api into hsml subdirectory"

This reverts commit c599739.
aversey pushed a commit to aversey/hopsworks-api that referenced this pull request Jul 19, 2024
@aversey aversey self-assigned this Jul 25, 2024
@aversey aversey deleted the the-merge-ruff branch August 21, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants