-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSTORE-1439][APPEND] Fix git blame for hsml + add missing commits from hsfs #235
Merged
aversey
merged 139 commits into
logicalclocks:main
from
aversey:main-after-revert-merge
Jul 22, 2024
Merged
[FSTORE-1439][APPEND] Fix git blame for hsml + add missing commits from hsfs #235
aversey
merged 139 commits into
logicalclocks:main
from
aversey:main-after-revert-merge
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogicalclocks#232) Co-authored-by: Javier de la Rúa Martínez <[email protected]>
…ml, upgrade doc dependencies (logicalclocks#227) * Upgrade dependencies, contributing.md, workflows * Fix contributing.md * Add minor change to contributing.md * Adapt to new material theme * Add minifier * Migrate to pyproject.toml * Change contributing * Run ruff check and ruff format * Minor mkdocs update * Update ruff and readme minor fix * Fix version typo * Add python version badges + code style changes * Fix import order messed up by merge * Add actual package to what should be installed * Fix color scheme * Add upper limit to the python version * Fix import order
* Update python requirement to <3.13 * Include hsml.* * Fix circular dependency
`get_first` is applied to early for model parents. Provenance methods should return the whole provenance information and only the wrappers should apply `get_first` on provenance.
… a profile in hsfs (logicalclocks#239)
* on-demand transformations * adding api for computing and transforming feature vectors * setting request parameters to {} if None * checking all element to check if multiple feature vectors are provided and adapting changes for save functions feature group
* Move type system converter to separate file * More work on migrating type_system converter * Minor clean ups * Move tests around * Moving more tests * Move infer_spark_type * More refactoring * Mino test cleanups * Fix mistype of _project_id in engine/python * Fix engine/test_spark --------- Co-authored-by: Aleksey Veresov <[email protected]>
* Merge variable_api of hsfs * Merge project_api of hsfs * Ruff project_api * Fix client/external so that Project API get_client works That is, set _project_id. * Fix Project API docs * Add docs to variable_api * Ruff client/external.py * Refactor variable_api
…ning-api * Remove redundant java-related files * Move java code of hsfs * Move locust_benchmark of hsfs * Move python code of hsfs * Move python code of hsml * Move hsml tests * Remove redundant __init__.py in hsml/tests * Move hsfs tests * Merge hsfs tests * Fix the problem with impure tests changing backend_fixtures One of the tests is impure, changing backend_fixtures, which breaks test_model. This commit makes backend_fixtures to return a deep copy of backend_fixtures_json isntead of returning them directly. * Fix ruff check of test_base_client * Move hsfs utils * Merge hsfs docs * Fix pyproject dependencies for hsfs docs * Merge the rest of hsfs docs * Merge hsfs mkdocs * Merge hsml docs * Add files generated by auto_doc to gitignore * Merge hsfs pyproject.toml * Merge hsml pyproject.toml * Remove hsfs and hsml pyproject.toml * Remove hive from pyproject dependencies * Fix mistypes in pyproject * Fix documentation generation * Fix circular dependencies * Fix circular dependency in hsml (CONNECTION_SAAS_HOSTNAME) * Fix circular dependency in hsml (model/util) * Ruff fix hsml/util * Fix docgen There is a very strange bug: hsml.python for some reason is available only as python.hsml.python. * Fix hsml.python import errors * Fix import problem in docgen * Ruff fix auto_doc *Revert the move of requirements-docs to an extra See PR logicalclocks#209 * Move workflows * Merge workflows * Remove redundant github files * Skip test_login until Robin is back * Fix test_connection * Fix test_hopsworks_udf * Fix import problem in docgen * Fix pyproject optional docgen dependency * Revert the move of requirements-docs to an extra See PR logicalclocks#209 * Rename unit_tests_pandas to unit_tests_pandas1 for clarity * Rename unit_tests_typechecked * Merge workflows * Fix import problem in docgen * Merge and remove the rest of python files * Merge gitignore * Move docker and jenkins files * Merge CONTRIBUTING * Merge README and remove hsfs and hsml subdirectories * Revert the move of requirements-docs to an extra See PR logicalclocks#209 * Add hopsworks_common
…epo (logicalclocks#232) * Ruff fix * Ruff format * Ruff fix * Revert making hsfs/client/base proper abstract class
…hopsworks_common (logicalclocks#229) * Move client * Move decorators, adapt client * Create aliases for client and decorators * Remove _python_version from client * Merge hsfs client * Move online_store_rest_client * Adapt online_store_rest_client * Create aliases for variable_api * Fix test_online_store_rest_client * Fix __all__ in client/__init__ * Merge hsfs/decorators * Move constants to hopsworks_common * Create alias for constants * Fix mistype in decorators * Move constants to core * Make alias for decorators in hsml * Fix hopsworks_common/client/hopsworks There was an error with incorrect number of parameters passed to _write_ca_chain.
…ks-api into main-after-revert-rebase
kennethmhc
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow during the merge of previous PR hsml commits were not added, and thus git blame and history of files are not working correctly.
Also some commits which were applied on Friday to hsfs are missing, for example logicalclocks/feature-store-api@b066aa9
For the reviewers: please take special attention if blame shows correctly in my repo, like it is here.