Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1439][APPEND] Fix git blame for hsml + add missing commits from hsfs #235

Merged
merged 139 commits into from
Jul 22, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Jul 19, 2024

Somehow during the merge of previous PR hsml commits were not added, and thus git blame and history of files are not working correctly.

Also some commits which were applied on Friday to hsfs are missing, for example logicalclocks/feature-store-api@b066aa9

For the reviewers: please take special attention if blame shows correctly in my repo, like it is here.

robzor92 and others added 30 commits September 13, 2021 17:24
)

* Refactor API and add default kafka topic and resources

* Fix inference_logger serialization
o-alex and others added 22 commits May 1, 2024 18:35
…ml, upgrade doc dependencies (logicalclocks#227)

* Upgrade dependencies, contributing.md, workflows

* Fix contributing.md

* Add minor change to contributing.md

* Adapt to new material theme

* Add minifier

* Migrate to pyproject.toml

* Change contributing

* Run ruff check and ruff format

* Minor mkdocs update

* Update ruff and readme minor fix

* Fix version typo

* Add python version badges + code style changes

* Fix import order messed up by merge

* Add actual package to what should be installed

* Fix color scheme

* Add upper limit to the python version

* Fix import order
* Update python requirement to <3.13

* Include hsml.*

* Fix circular dependency
`get_first` is applied to early for model parents. Provenance methods should return the whole provenance information and only the wrappers should apply `get_first` on provenance.
* on-demand transformations

* adding api for computing and transforming feature vectors

* setting request parameters to {} if None

* checking all element to check if multiple feature vectors are provided and adapting changes for save functions feature group
* Move type system converter to separate file

* More work on migrating type_system converter

* Minor clean ups

* Move tests around

* Moving more tests

* Move infer_spark_type

* More refactoring

* Mino test cleanups

* Fix mistype of _project_id in engine/python

* Fix engine/test_spark

---------

Co-authored-by: Aleksey Veresov <[email protected]>
* Merge variable_api of hsfs

* Merge project_api of hsfs

* Ruff project_api

* Fix client/external so that Project API get_client works

That is, set _project_id.

* Fix Project API docs

* Add docs to variable_api

* Ruff client/external.py

* Refactor variable_api
…ning-api

* Remove redundant java-related files

* Move java code of hsfs

* Move locust_benchmark of hsfs

* Move python code of hsfs

* Move python code of hsml

* Move hsml tests

* Remove redundant __init__.py in hsml/tests

* Move hsfs tests

* Merge hsfs tests

* Fix the problem with impure tests changing backend_fixtures

One of the tests is impure, changing backend_fixtures, which breaks test_model.
This commit makes backend_fixtures to return a deep copy of backend_fixtures_json isntead of returning them directly.

* Fix ruff check of test_base_client

* Move hsfs utils

* Merge hsfs docs

* Fix pyproject dependencies for hsfs docs

* Merge the rest of hsfs docs

* Merge hsfs mkdocs

* Merge hsml docs

* Add files generated by auto_doc to gitignore

* Merge hsfs pyproject.toml

* Merge hsml pyproject.toml

* Remove hsfs and hsml pyproject.toml

* Remove hive from pyproject dependencies

* Fix mistypes in pyproject

* Fix documentation generation

* Fix circular dependencies

* Fix circular dependency in hsml (CONNECTION_SAAS_HOSTNAME)

* Fix circular dependency in hsml (model/util)

* Ruff fix hsml/util

* Fix docgen

There is a very strange bug: hsml.python for some reason is available only as python.hsml.python.

* Fix hsml.python import errors

* Fix import problem in docgen

* Ruff fix auto_doc

*Revert the move of requirements-docs to an extra

See PR logicalclocks#209

* Move workflows

* Merge workflows

* Remove redundant github files

* Skip test_login until Robin is back

* Fix test_connection

* Fix test_hopsworks_udf

* Fix import problem in docgen

* Fix pyproject optional docgen dependency

* Revert the move of requirements-docs to an extra

See PR logicalclocks#209

* Rename unit_tests_pandas to unit_tests_pandas1 for clarity

* Rename unit_tests_typechecked

* Merge workflows

* Fix import problem in docgen

* Merge and remove the rest of python files

* Merge gitignore

* Move docker and jenkins files

* Merge CONTRIBUTING

* Merge README and remove hsfs and hsml subdirectories

* Revert the move of requirements-docs to an extra

See PR logicalclocks#209

* Add hopsworks_common
…epo (logicalclocks#232)

* Ruff fix

* Ruff format

* Ruff fix

* Revert making hsfs/client/base proper abstract class
This reverts commit d8f3979, reversing
changes made to c599739.
…hopsworks_common (logicalclocks#229)

* Move client

* Move decorators, adapt client

* Create aliases for client and decorators

* Remove _python_version from client

* Merge hsfs client

* Move online_store_rest_client

* Adapt online_store_rest_client

* Create aliases for variable_api

* Fix test_online_store_rest_client

* Fix __all__ in client/__init__

* Merge hsfs/decorators

* Move constants to hopsworks_common

* Create alias for constants

* Fix mistype in decorators

* Move constants to core

* Make alias for decorators in hsml

* Fix hopsworks_common/client/hopsworks

There was an error with incorrect number of parameters passed to _write_ca_chain.
@aversey aversey merged commit 6cc8e4d into logicalclocks:main Jul 22, 2024
26 checks passed
@aversey aversey self-assigned this Jul 25, 2024
@aversey aversey deleted the main-after-revert-merge branch August 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.