[HWORKS-1565][APPEND] Make sure the spark program exits after completion #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in which exceptions are lost if a spark Job Fails.
Root Cause:
PR #275 added a
system.exit(1)
to kill the Kubernetes pod in case of spark Job Failure. However this causes the exception logs to be lost since they are not re-raised after the finally block.https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions
Fix Done:
As a temporary fix the exceptions before calling System.exit(1). Jira ticket has been created for further investigation of the need for a System.exit
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: