Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HWORKS-1565][APPEND] Make sure the spark program exits after completion #334

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

manu-sj
Copy link
Contributor

@manu-sj manu-sj commented Sep 16, 2024

This PR fixes the issue in which exceptions are lost if a spark Job Fails.

Root Cause:
PR #275 added a system.exit(1) to kill the Kubernetes pod in case of spark Job Failure. However this causes the exception logs to be lost since they are not re-raised after the finally block.

https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions

Fix Done:
As a temporary fix the exceptions before calling System.exit(1). Jira ticket has been created for further investigation of the need for a System.exit

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@manu-sj manu-sj requested a review from robzor92 September 17, 2024 07:33
@manu-sj manu-sj merged commit ddc9308 into logicalclocks:main Sep 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants