Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1572] Add finalizer to Connection #365

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Oct 18, 2024

JIRA Issue: FSTORE-1572

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey self-assigned this Oct 18, 2024
@aversey aversey requested a review from vatj October 21, 2024 09:14
@aversey aversey merged commit 44cedc0 into logicalclocks:main Oct 22, 2024
13 checks passed
@aversey aversey deleted the connection-finalize branch October 22, 2024 07:53
manu-sj added a commit to manu-sj/hopsworks-api that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants