Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSTORE-1522] Deduplicate most of hsml #368

Merged
merged 23 commits into from
Dec 4, 2024
Merged

[FSTORE-1522] Deduplicate most of hsml #368

merged 23 commits into from
Dec 4, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Oct 22, 2024

JIRA Issue: FSTORE-1522

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

aversey and others added 20 commits September 3, 2024 10:44
@aversey
Add missing init in hopsworks_common.engine
b411cde
@aversey
Add missing FeatureStoreEncoder to hsfs.util for backwards compatibility
1655ba9
@aversey
Deduplicate util
96ffc37
@aversey
Deduplicate kafka_topic
8c5dfd0
@aversey
Make direct imports instead of through aliases
d508710
@aversey
Deduplicate tag
10d4fad
@aversey
Deduplicate dataset_api
a8051aa
@aversey
Merge branch 'logicalclocks:main' into dedup-hsml
a3ed308
@aversey
Fix tag import
af832f8
@aversey
Fix KafkaTopic
6834a24
@aversey
Fix mocking of get_obj_from_json
4c7efec
@aversey
Fix mocking
4ee0a07
@aversey
Fix mocking of hsml.util
8b8321f
@aversey
Fix mocking and imports of util
0e8c87c
@aversey
Fix KafkaTopic.from_reposnse_json
abd00b6
@aversey
Fix pandas typechecking in util
3eb1974
@aversey
Fix mocking in test_predictor
b320566
@aversey
Fix mocking in test_resources
dd88d00
@aversey
Fix mocking in test_transformer
b30f8b0
@aversey
Merge remote-tracking branch 'origin/main' into dedup-hsml
7479664
@aversey aversey requested review from javierdlrm and vatj October 22, 2024 08:18
@aversey aversey self-assigned this Oct 22, 2024
@aversey aversey merged commit 47be364 into logicalclocks:main Dec 4, 2024
13 checks passed
@aversey aversey deleted the dedup-hsml branch December 4, 2024 14:32
davitbzh pushed a commit to davitbzh/hopsworks-api that referenced this pull request Dec 5, 2024
@aversey
[FSTORE-1522] Deduplicate most of hsml (logicalclocks#368)
656aa01 
* Add missing init in hopsworks_common.engine

* Add missing FeatureStoreEncoder to hsfs.util for backwards compatibility

* Deduplicate util

* Deduplicate kafka_topic

* Make direct imports instead of through aliases

* Deduplicate tag

* Deduplicate dataset_api

* Fix tag import

* Fix KafkaTopic

* Fix mocking of get_obj_from_json

* Fix mocking

* Fix mocking of hsml.util

* Fix mocking and imports of util

* Fix KafkaTopic.from_reposnse_json

* Fix pandas typechecking in util

* Fix mocking in test_predictor

* Fix mocking in test_resources

* Fix mocking in test_transformer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierdlrm javierdlrm javierdlrm approved these changes

@vatj vatj Awaiting requested review from vatj

Assignees

@aversey aversey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aversey @javierdlrm