[FSTORE-1645] Catch HSML initialization permission-related errors in login #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatj
requested changes
Dec 17, 2024
| except RestAPIError as e: | ||
| if e.response.error_code == 403: | ||
| print( | ||
| "You lack permission to initialize model serving. Machine learning functionality will be not available." |
There was a problem hiding this comment.
Suggested change
| "You lack permission to initialize model serving. Machine learning functionality will be not available." | |
| "Api key does not include "SERVING" scope, related functionality will be disabled." |
There was a problem hiding this comment.
This message may be misleading, since the code catches all 403. I'll think about this and hopefully come up with a better solution.
| print( | ||
| "You lack permission to initialize model serving. Machine learning functionality will be not available." | ||
| ) | ||
| print("The permission-related exception is:", e) |
There was a problem hiding this comment.
Can you use a debug/exception logger for the second print instead?
There was a problem hiding this comment.
I printed it for the same reason as is explained above. I will change it to use the debug logger.
vatj
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issue: FSTORE-1645