use model dimension (#254)

logicalclocks · Apr 12, 2024 · 08afa48 · 08afa48
1 parent 705df23
commit 08afa48
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/api_examples/hsfs/knn_search/news-search-knn-save-model.ipynb b/api_examples/hsfs/knn_search/news-search-knn-save-model.ipynb
@@ -197,8 +197,8 @@
     "\n",
     "emb = embedding.EmbeddingIndex(index_name=f\"news_fg_{version}\")\n",
     "# specify the name, dimension, and model of the embedding features \n",
-    "emb.add_embedding(\"embedding_body\", len(df[\"embedding_body\"][0]), model=hsml_model)\n",
-    "emb.add_embedding(\"embedding_heading\", len(df[\"embedding_heading\"][0]), model=hsml_model)"
+    "emb.add_embedding(\"embedding_body\", model.get_sentence_embedding_dimension(), model=hsml_model)\n",
+    "emb.add_embedding(\"embedding_heading\", model.get_sentence_embedding_dimension(), model=hsml_model)"
    ]
   },
   {

diff --git a/api_examples/hsfs/knn_search/news-search-knn.ipynb b/api_examples/hsfs/knn_search/news-search-knn.ipynb
@@ -189,8 +189,8 @@
    "outputs": [],
    "source": [
     "# specify the name and dimension of the embedding features \n",
-    "emb.add_embedding(\"embedding_body\", len(df[\"embedding_body\"][0]))\n",
-    "emb.add_embedding(\"embedding_heading\", len(df[\"embedding_heading\"][0]))"
+    "emb.add_embedding(\"embedding_body\", model.get_sentence_embedding_dimension())\n",
+    "emb.add_embedding(\"embedding_heading\", model.get_sentence_embedding_dimension())"
    ]
   },
   {
@@ -340,7 +340,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.10.0"
+   "version": "3.10.13"
   }
  },
  "nbformat": 4,