[FSTORE-1010] Don't leave orphaned subjects when deleting online enab…

…led fg (#1547)
logicalclocks · Sep 17, 2023 · 940c28a · 940c28a
1 parent fdf6182
commit 940c28a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/.../hops/hopsworks/common/featurestore/featuregroup/online/OnlineFeaturegroupController.java b/.../hops/hopsworks/common/featurestore/featuregroup/online/OnlineFeaturegroupController.java
@@ -213,6 +213,10 @@ public void disableOnlineFeatureGroup(Featuregroup featureGroup, Project project
       throws FeaturestoreException, SQLException, SchemaException, KafkaException {
     dropMySQLTable(featureGroup, project, user);
     String topicName = Utils.getFeatureGroupTopicName(featureGroup);
+    String featureGroupEntityName = Utils.getFeaturegroupName(featureGroup);
+    if (!subjectsController.getSubjectVersions(project, featureGroupEntityName).isEmpty()) {
+      subjectsController.deleteSubject(project, featureGroupEntityName);
+    }
     // HOPSWORKS-3252 - we keep kafka topics in order to avoid consumers getting blocked
     // deleteFeatureGroupKafkaTopic(project, topicName);
   }