[FSTORE-752] Online type consistency issue (#1310)

logicalclocks · Apr 19, 2023 · d1a3159 · d1a3159
1 parent c763572
commit d1a3159
Show file tree

Hide file tree

Showing 2 changed files with 402 additions and 5 deletions.
diff --git a/.../java/io/hops/hopsworks/common/featurestore/featuregroup/FeatureGroupInputValidation.java b/.../java/io/hops/hopsworks/common/featurestore/featuregroup/FeatureGroupInputValidation.java
@@ -45,16 +45,18 @@
 public class FeatureGroupInputValidation {
 
   @EJB
-  private FeaturestoreInputValidation featureStoreInputValidation;
+  protected FeaturestoreInputValidation featureStoreInputValidation;
   @EJB
-  private OnlineFeaturegroupController onlineFeaturegroupController;
+  protected OnlineFeaturegroupController onlineFeaturegroupController;
 
   public FeatureGroupInputValidation() {
   }
 
   // for testing
-  public FeatureGroupInputValidation(FeaturestoreInputValidation featureStoreInputValidation) {
+  public FeatureGroupInputValidation(FeaturestoreInputValidation featureStoreInputValidation,
+                                     OnlineFeaturegroupController onlineFeaturegroupController) {
     this.featureStoreInputValidation = featureStoreInputValidation;
+    this.onlineFeaturegroupController = onlineFeaturegroupController;
   }
 
   /**
@@ -164,7 +166,8 @@ public void verifyOnlineOfflineTypeMatch(FeaturegroupDTO featuregroupDTO) throws
 
         if ((offlineType.startsWith("array") ||
           offlineType.startsWith("struct") ||
-          offlineType.startsWith("binary")) &&
+          offlineType.startsWith("binary") ||
+          offlineType.startsWith("map")) &&
           (onlineType.startsWith("varbinary") || onlineType.equals("blob"))) {
           continue;
         }