Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jenkinsfile to also build webhook and controller images #6

Closed
wants to merge 2 commits into from

Conversation

gibchikafa
Copy link
Collaborator

What changes were proposed in this pull request?

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: # (issue)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

No.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

jerqi and others added 2 commits October 17, 2024 11:37
…pache#1813)

### What changes were proposed in this pull request?
Previous pull request is apache#466

Supports mounting PVC for shuffleserver

### Why are the changes needed?

Fix: apache#288 

### Does this PR introduce _any_ user-facing change?
Yes, added the document.

### How was this patch tested?
Add uts and test by hand in the GKE.

Co-authored-by: alexcqtan <[email protected]>
Copy link

@maismail maismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump the docker image versions

Copy link

Test Results

 2 357 files   - 6   2 357 suites   - 6   4h 37m 34s ⏱️ - 2m 9s
   917 tests ±0     915 ✅  - 1   1 💤 ±0  0 ❌ ±0  1 🔥 +1 
10 632 runs   - 6  10 617 ✅  - 7  14 💤 ±0  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 652a453. ± Comparison against base commit 1e3aac8.

@maismail maismail closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants