[HWORKS-1722] Fix Jenkinsfile to also build webhook and controller images. Make it possible for image to be run by any user. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#1813) ### What changes were proposed in this pull request? Previous pull request is apache#466 Supports mounting PVC for shuffleserver ### Why are the changes needed? Fix: apache#288 ### Does this PR introduce _any_ user-facing change? Yes, added the document. ### How was this patch tested? Add uts and test by hand in the GKE. Co-authored-by: alexcqtan <[email protected]>
…possible for image to be run by any user.
gibchikafa
force-pushed
the
branch-0.9.1
branch
from
e2245b8 to
167bd6c
Compare
gibchikafa
changed the title
maismail
approved these changes
Oct 17, 2024
gibchikafa
changed the title
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
gibchikafa
merged commit 2718123
into
logicalclocks:branch-0.9.1
39 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: # (issue)
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
No.
How was this patch tested?
(Please test your changes, and provide instructions on how to test it: