Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOUD-700] Add support for GCP #294

Merged
merged 13 commits into from
Jan 30, 2024
Merged

Conversation

maismail
Copy link
Contributor

Make sure there is no duplicate PR for this issue

  • Please check if the PR meets the following requirements

    • Adds tests for the submitted changes (for bug fixes & features)
    • Passes the tests including acceptance test
    • An issue has been opened for this PR
    • Updates the change log
    • All commits have been squashed down to a single commit
  • Close the associated issue

    Closes https://hopsworks.atlassian.net/browse/CLOUD-700

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1a522b4) 91.43% compared to head (75794ac) 91.87%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rce_gcp_service_account_custom_role_permissions.go 95.31% 2 Missing and 1 partial ⚠️
hopsworksai/resource_cluster_from_backup.go 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   91.43%   91.87%   +0.43%     
==========================================
  Files          23       24       +1     
  Lines        3479     3741     +262     
==========================================
+ Hits         3181     3437     +256     
- Misses        219      224       +5     
- Partials       79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/complete/gcp/basic/README.md Outdated Show resolved Hide resolved
examples/complete/gcp/gke/autopilot/README.md Outdated Show resolved Hide resolved
examples/complete/gcp/gke/standard/README.md Outdated Show resolved Hide resolved
examples/complete/gcp/gke/standard/main.tf Outdated Show resolved Hide resolved
hopsworksai/resource_cluster.go Show resolved Hide resolved
@maismail maismail merged commit de716a4 into logicalclocks:main Jan 30, 2024
5 checks passed
@maismail maismail deleted the CLOUD-700 branch January 30, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants