Leave nil values untouched in conversions.

logicblocks · Jun 2, 2024 · c422b71 · c422b71
1 parent 6b7fdb8
commit c422b71
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/configurati/conversions.clj b/src/configurati/conversions.clj
@@ -10,6 +10,7 @@
 
 (defmethod convert-to :boolean [_ value]
   (cond
+    (nil? value) nil
     (or (= "true" value) (true? value)) true
     (or (= "false" value) (false? value)) false
     :else

diff --git a/test/configurati/conversions_test.clj b/test/configurati/conversions_test.clj
@@ -20,6 +20,8 @@
           (conf-conv/convert-to :integer Integer/MAX_VALUE)))
     (is (= Integer/MIN_VALUE
           (conf-conv/convert-to :integer Integer/MIN_VALUE))))
+  (testing "leaves nil untouched"
+    (is (= nil (conf-conv/convert-to :integer nil))))
   (testing "throws for non-integral values"
     (is (thrown? Exception
           (conf-conv/convert-to :integer "hello there")))
@@ -37,7 +39,9 @@
   (testing "leaves string untouched"
     (is (= "hello" (conf-conv/convert-to :string "hello")))
     (is (= "5" (conf-conv/convert-to :string "5")))
-    (is (= "true" (conf-conv/convert-to :string "true")))))
+    (is (= "true" (conf-conv/convert-to :string "true"))))
+  (testing "leaves nil untouched"
+    (is (= nil (conf-conv/convert-to :string nil)))))
 
 (deftest boolean-conversion
   (testing "converts values to boolean"
@@ -46,6 +50,8 @@
   (testing "leaves booleans untouched"
     (is (= true (conf-conv/convert-to :boolean true)))
     (is (= false (conf-conv/convert-to :boolean false))))
+  (testing "leaves nil untouched"
+    (is (= nil (conf-conv/convert-to :boolean nil))))
   (testing "throws for non-boolean values"
     (is (thrown? Exception
           (conf-conv/convert-to :boolean "spinach"))))