Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node envconfig #382

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Node envconfig #382

merged 5 commits into from
Sep 11, 2023

Conversation

bacv
Copy link
Member

@bacv bacv commented Sep 7, 2023

Exposed some parameters to be configured via the cli or env variables.
If this approach is acceptable, then I'll create a new PR for metrics configuration, as node currently uses MapMetricsBackend instead of Graphql.

@bacv bacv added the node label Sep 7, 2023
@bacv bacv added this to the Nomos testnet (playground) milestone Sep 7, 2023
@bacv bacv self-assigned this Sep 7, 2023
Copy link
Contributor

@al8n al8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
nodes/nomos-node/src/config.rs 0.00%
nodes/nomos-node/src/lib.rs ø
nodes/nomos-node/src/main.rs 0.00%

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra mile! Thanks!

nodes/nomos-node/config.yaml Show resolved Hide resolved
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks much more flexible.

@bacv bacv merged commit 8e0937b into master Sep 11, 2023
11 of 13 checks passed
@bacv bacv deleted the node-envconfig branch September 11, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants