Simulations: make polars dependancy optional #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
bacv
force-pushed
the
gh/windows-build
branch
from
3711e21
to
e7b6338
Compare
bacv
force-pushed
the
gh/windows-build
branch
from
e7b6338
to
428dc06
Compare
bacv
changed the title
danielSanchezQ
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows builds are failing, the exact reason is not obvious.
After some investigation, the failure is not clear still, but the build fails for polars crate. As this feature is not essential to simulations, I've just made it optional and not built in ci related tests.