Da nomos core #390
Da nomos core #390
Conversation
Include da core module in nomos-core
| fn encode<T: AsRef<[u8]>>(&self, data: T) -> Box<dyn Stream<Item = Self::Blob>>; | ||
| fn decode<S: Stream<Item = Self::Blob>>(&self, s: S) -> Result<Bytes, Box<dyn Error>>; | ||
| fn validate(&self, blob: &Self::Blob, attestation: &Self::Attestation) -> bool; | ||
| } |
There was a problem hiding this comment.
is this supposed to validate a single attestation or the full proof?
There was a problem hiding this comment.
Validate the attestation for an specific blob. We should probably add a trait method to create a certificate over the set of attestations. I'll add now as well
There was a problem hiding this comment.
maybe also a method to validate said certificate?
| @@ -25,4 +25,6 @@ pub trait DaProtocol { | |||
| &self, | |||
| attestations: S, | |||
| ) -> Self::Certificate; | |||
|
|
|||
| fn validate_certificate(certificate: &Self::Certificate) -> bool; | |||
There was a problem hiding this comment.
should this have the blob in input?
EDIT: I think it's actually ok for now since we don't know much yet
There was a problem hiding this comment.
I'm not really sure, actually. Maybe we need to validate the certificate over the original data?
In this case certificate is the aggregation of attestations that proofs that data is distributed. Either we can check it stand alone or for all blobs (?)
There was a problem hiding this comment.
I guess having something Certificate::blob is sufficient, you would then check that the certificate itself is valid on chain and you have the blob id to retrieve it if necessary
There was a problem hiding this comment.
I think we are calling blob different stuff here (it may be my fault in naming actually). A blob is what a node receives (and it may be just a chunk of the original data). Being the certificate an aggregation of attestations (refering to a blob) its difficult the certificate can return a single id of a single blob. In this case I see two things. I can rename it to Blob (the whole data) and BlobChunk (a blob that a node receives). Or we consider the orinal data blob just data and pass away the hash of the whole thing (but I am not really sure we need this anyway, as it may be better to have validation methods where needed instead?).
There was a problem hiding this comment.
You're right, I was confusing those terms. I think the fact that it might be sharded it's a protocol detail (e.g. we do that with rs encoding but not with full replication), while the concept of bl-blobs is independent of the way we do data availability, it's just a piece of data that is available somewhere.
There was a problem hiding this comment.
But anyway, in the case of a full replication we would just create a Blob that contains the same data for each of them (encoding non-encoding 😂 ). I think for now we can assume that the certificate can be validated by itself, and we can change it later if we see fit?
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
This is just an initial approach. Will change/grow as needed now when implementing the first working versions.
We aim to have generic implementation that can be changed easily later on.
AttestationtraitDaProtocoltrait