Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concrete Error implementation for mixnet #405

Merged
merged 48 commits into from
Sep 25, 2023
Merged

Add concrete Error implementation for mixnet #405

merged 48 commits into from
Sep 25, 2023

Conversation

al8n
Copy link
Contributor

@al8n al8n commented Sep 14, 2023

Solve #387.

youngjoon-lee and others added 30 commits August 21, 2023 22:52
@youngjoon-lee
Add mixnode and mixnet-client crate (#302)
d57efc3
@youngjoon-lee
Add mixnode binary (#317)
0a38fd3
@youngjoon-lee
Integrate mixnet with libp2p network backend (#318)
b692043
@al8n
Fix #312: proper delays (#321)
f578217 
* proper delays
@al8n
add missing duration param
5a5aa1f
@al8n
Merge branch 'master' into mixnet
4621c0a
@youngjoon-lee
Merge branch 'master' into mixnet
9798ff0
@youngjoon-lee
tiny fix: compilation error caused by rand 0.8 -> 0.7
030baa7
@youngjoon-lee
Merge branch 'master' into mixnet
e725af0
@youngjoon-lee
use get_available_port() for mixnet integration tests (#333)
292f393
@danielSanchezQ
Merge branch 'master' into mixnet
7df010e
@youngjoon-lee
add missing comments
723ebfe
@danielSanchezQ @youngjoon-lee
Overwatch mixnet node (#339)
33a4823 
* Add mixnet service and overwatch app

* remove #[tokio::main]

---------

Co-authored-by: Youngjoon Lee <[email protected]>
@youngjoon-lee
fix tests for the overwatch mixnode (#342)
e8f2c38
@al8n
fix panic when corner case happen in RandomDelayIter (#335)
82421ce
@youngjoon-lee
Use log service for mixnode bin (#341)
361032e
@youngjoon-lee
Merge branch 'master' into mixnet
190a955
@youngjoon-lee
Use wire for MixnetMessage in libp2p (#347)
d00ca2a
@youngjoon-lee
Prevent tmixnet tests from running forever (#363)
25c8ae0
@youngjoon-lee
Use random delay when sending msgs to mixnet (#362)
b11d2cb
@youngjoon-lee
Merge branch 'master' into mixnet
3468d7c
@youngjoon-lee
fix a minor compilation error caused by the latest master
73360d7
@al8n
Fix run output fd (#343)
b122867 
* add a connection pool
@youngjoon-lee
Merge branch 'master' into mixnet
798a847
@zeegomo
Exp backoff (#332)
2a0a6c9 
* move mixnet listening into separate task

* add exponential retry for insufficient peers in libp2p

* fix logging
@zeegomo @youngjoon-lee
Fix MutexGuard across await (#373)
a21a8a9 
* Fix MutexGuard across await

Holding a MutexGuard across an await point is not a good idea.
Removing that solves the issues we had with the mixnet test

* Make mixnode handle bodies coming from the same source concurrently (#372)

---------

Co-authored-by: Youngjoon Lee <[email protected]>
@zeegomo
Move wait at network startup (#338)
e50ef09 
We now wait after the call to 'subscribe' to give the network
the time to register peers in the mesh before starting to
publish messages
@youngjoon-lee
Remove unused functions from mixnet connpool (#374)
e1ab1a7
@youngjoon-lee
Mixnet benchmark (#375)
0950782
@youngjoon-lee
Merge branch 'master' into mixnet
2db4862
@al8n al8n added enhancement New feature or request mixnet labels Sep 14, 2023
@al8n al8n added this to the Mixnet milestone Sep 14, 2023
@al8n al8n self-assigned this Sep 14, 2023
danielSanchezQ
danielSanchezQ approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@al8n al8n changed the base branch from mixnet to master September 14, 2023 08:49
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Patch coverage is 85.07% of modified lines.

Files Changed Coverage
mixnet/client/src/error.rs 0.00%
mixnet/node/src/client_notifier.rs 57.14%
mixnet/node/src/lib.rs 83.33%
mixnet/protocol/src/lib.rs 85.71%
mixnet/client/src/lib.rs 100.00%
mixnet/client/src/receiver.rs 100.00%
mixnet/client/src/sender.rs 100.00%
mixnet/topology/src/lib.rs 100.00%

📢 Thoughts on this report? Let us know!.

@al8n al8n linked an issue Sep 15, 2023 that may be closed by this pull request
Construct a concrete Error by something like thiserror for mixnet. #387
Closed
youngjoon-lee
youngjoon-lee approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

mixnet/topology/src/lib.rs Outdated Show resolved Hide resolved
mixnet/topology/src/lib.rs Outdated Show resolved Hide resolved
mixnet/node/src/lib.rs Outdated Show resolved Hide resolved
@al8n al8n merged commit cb34315 into master Sep 25, 2023
12 checks passed
@al8n al8n deleted the mixnet-error branch September 25, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielSanchezQ danielSanchezQ danielSanchezQ approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@zeegomo zeegomo Awaiting requested review from zeegomo

Assignees

@al8n al8n

Labels
enhancement New feature or request mixnet
Projects
None yet
Milestone
Mixnet
Development

Successfully merging this pull request may close these issues.

Construct a concrete Error by something like thiserror for mixnet.
4 participants
@al8n @danielSanchezQ @youngjoon-lee @zeegomo