Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concrete Error implementation for mixnet #405

Merged
merged 48 commits into from
Sep 25, 2023
Merged

Add concrete Error implementation for mixnet #405

merged 48 commits into from
Sep 25, 2023

Conversation

al8n
Copy link
Contributor

@al8n al8n commented Sep 14, 2023

Solve #387.

youngjoon-lee and others added 30 commits August 21, 2023 22:52
* Add mixnet service and overwatch app

* remove #[tokio::main]

---------

Co-authored-by: Youngjoon Lee <[email protected]>
* add a connection pool
* move mixnet listening into separate task

* add exponential retry for insufficient peers in libp2p

* fix logging
* Fix MutexGuard across await

Holding a MutexGuard across an await point is not a good idea.
Removing that solves the issues we had with the mixnet test

* Make mixnode handle bodies coming from the same source concurrently (#372)

---------

Co-authored-by: Youngjoon Lee <[email protected]>
We now wait after the call to 'subscribe' to give the network
the time to register peers in the mesh before starting to
publish messages
@al8n al8n added enhancement New feature or request mixnet labels Sep 14, 2023
@al8n al8n added this to the Mixnet milestone Sep 14, 2023
@al8n al8n self-assigned this Sep 14, 2023
Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@al8n al8n changed the base branch from mixnet to master September 14, 2023 08:49
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage is 85.07% of modified lines.

Files Changed Coverage
mixnet/client/src/error.rs 0.00%
mixnet/node/src/client_notifier.rs 57.14%
mixnet/node/src/lib.rs 83.33%
mixnet/protocol/src/lib.rs 85.71%
mixnet/client/src/lib.rs 100.00%
mixnet/client/src/receiver.rs 100.00%
mixnet/client/src/sender.rs 100.00%
mixnet/topology/src/lib.rs 100.00%

📢 Thoughts on this report? Let us know!.

@al8n al8n linked an issue Sep 15, 2023 that may be closed by this pull request
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

mixnet/topology/src/lib.rs Outdated Show resolved Hide resolved
mixnet/topology/src/lib.rs Outdated Show resolved Hide resolved
mixnet/node/src/lib.rs Outdated Show resolved Hide resolved
@al8n al8n merged commit cb34315 into master Sep 25, 2023
12 checks passed
@al8n al8n deleted the mixnet-error branch September 25, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mixnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Construct a concrete Error by something like thiserror for mixnet.
4 participants