Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor libp2p network backend into submodules #417

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Sep 19, 2023

Refactored the libp2p network backend, so that we can extend it easily.

This PR just splits a verbose libp2p.rs into several submodules (without any serious modifications, to not make this PR hard to review).

  • e444503: Moved Config and Command into separate modules
  • 2d8c75d: Split the verbose Libp2p::new() into two separated modules: SwarmHandler and MixnetHandler.

At next PRs, I'm going to refine them more and add metrics feature for the libp2p backend.

@youngjoon-lee youngjoon-lee self-assigned this Sep 19, 2023
@youngjoon-lee youngjoon-lee changed the title Refactor libp2p network backend Refactor libp2p network backend into submodules Sep 19, 2023
Copy link
Contributor

@al8n al8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better indeed. Thanks!

@youngjoon-lee youngjoon-lee merged commit e0cd35d into master Sep 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants