Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #433

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Remove unnecessary dependencies #433

merged 3 commits into from
Sep 25, 2023

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Sep 22, 2023

Using cargo-udeps, I removed unnecessary dependencies. The udeps commands that I used are below:

cargo +nightly udeps --all --all-targets --no-default-features --tests --benches --features waku,metrics,gql
cargo +nightly udeps --all --all-targets --no-default-features --tests --benches --features libp2p,metrics,gql

I deleted dependencies that were the intersection of two results (which aren't used by both waku and libp2p).

@youngjoon-lee youngjoon-lee self-assigned this Sep 22, 2023
@youngjoon-lee youngjoon-lee marked this pull request as ready for review September 22, 2023 04:41
@youngjoon-lee youngjoon-lee merged commit 285804e into master Sep 25, 2023
12 checks passed
@youngjoon-lee youngjoon-lee deleted the udeps branch September 25, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants