Add PoL #718
Merged
Add PoL #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
force-pushed
the
add-pol
branch
6 times, most recently
from
4f74f3a
to
d5cdc22
Compare
danielSanchezQ
approved these changes
Sep 3, 2024
thomaslavaur
reviewed
Sep 3, 2024
|
|
||
| pub fn leaf(data: &[u8]) -> [u8; 32] { | ||
| let mut hasher = Sha256::new(); | ||
| hasher.update(b"NOMOS_MERKLE_LEAF"); |
There was a problem hiding this comment.
We should consider moving to tag codes if necessary. In Merkle tree constraints, that could save a lot of cycles.
There was a problem hiding this comment.
Could you elaborate?
bacv
reviewed
Sep 3, 2024
| cl = { path = "../../../cl/cl" } | ||
| leader_proof_statements = { path = "../../proof_statements" } | ||
| nomos_pol_risc0_proofs = { path = "../risc0_proofs" } | ||
| risc0-zkvm = { version = "1.0", features = ["prove", "metal"] } |
There was a problem hiding this comment.
Could it be that the risc0 test fails because metal feature flag is being used on the linux host?
bacv
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote PoL and CL crates from nomos-pocs.
CL is mostly unchanged, while PoL has gone through some refactors. I didn't include the crate in the workspace as it has special build instruction and e.g. does not support clippy