-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve coverage workflow #738
Conversation
- run tests to get coverage
Based on tests in my fork original wf would finish successfully, but no coverage would render on codecov.io Is the infrequent update on https://app.codecov.io/gh/logos-co/nomos-node/commits due to our license ? |
Right now, coverage workflow takes around 26 minutes. If that is too long to have it after each push, I can change it as scheduled, once a day for example? https://github.com/romanzac/nomos-node/actions/runs/10896693219 |
Your suggestion to have coverage workflow less frequently is great, at least for the short term. I think once a day would be a good option. Regarding the changes in PR, I would keep grcov installed with the |
- use binstall for grcov
Changed since 01f8994 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Few changes to tweak coverage workflow to occupy less disk space and run tests.