Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve coverage workflow #738

Merged
merged 3 commits into from
Sep 18, 2024
Merged

chore: Improve coverage workflow #738

merged 3 commits into from
Sep 18, 2024

Conversation

romanzac
Copy link
Contributor

Few changes to tweak coverage workflow to occupy less disk space and run tests.

- run tests to get coverage
@romanzac
Copy link
Contributor Author

Based on tests in my fork original wf would finish successfully, but no coverage would render on codecov.io
https://github.com/romanzac/nomos-node/actions/runs/10845309954
https://app.codecov.io/gh/romanzac/nomos-node/commit/11f0a3b4b8aa7f651915e371e9b2c3e70f6549a9

Is the infrequent update on https://app.codecov.io/gh/logos-co/nomos-node/commits due to our license ?

@romanzac romanzac marked this pull request as ready for review September 17, 2024 05:33
@romanzac
Copy link
Contributor Author

Right now, coverage workflow takes around 26 minutes. If that is too long to have it after each push, I can change it as scheduled, once a day for example?

https://github.com/romanzac/nomos-node/actions/runs/10896693219

@bacv
Copy link
Member

bacv commented Sep 17, 2024

Right now, coverage workflow takes around 26 minutes. If that is too long to have it after each push, I can change it as scheduled, once a day for example?

Your suggestion to have coverage workflow less frequently is great, at least for the short term. I think once a day would be a good option. Regarding the changes in PR, I would keep grcov installed with the binstall, that would use even less space.

- use binstall for grcov
@romanzac
Copy link
Contributor Author

fix: schedule on 3am UTC

Changed since 01f8994

Copy link
Member

@bacv bacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@romanzac romanzac merged commit fadf6d0 into master Sep 18, 2024
8 checks passed
@romanzac romanzac deleted the chore-coverage-workflow branch September 18, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants