Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone and copy to CoverTrafficSettings #911

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Nov 7, 2024

1. What does this PR implement?

Add clone and copy to CoverTrafficSettings

2. Does the code have enough context to be clearly understood?

N/A

3. Who are the specification authors and who is accountable for this PR?

@danielSanchezQ @AlejandroCabeza

4. Is the specification accurate and complete?

N/A

5. Does the implementation introduce changes in the specification?

N/A

Checklist

Warning

Do not merge the PR if any of the following is missing:

  • 1. Description added.
  • 2. Context and links to Specification document(s) added.
  • 3. Main contact(s) (developers and specification authors) added
  • 4. Implementation and Specification are 100% in sync including changes. This is critical.
  • 5. Link PR to a specific milestone.

@danielSanchezQ danielSanchezQ added bug Something isn't working mixnet labels Nov 7, 2024
@danielSanchezQ danielSanchezQ added this to the Iteration 8 milestone Nov 7, 2024
@danielSanchezQ danielSanchezQ merged commit 1c62ced into master Nov 7, 2024
5 checks passed
@danielSanchezQ danielSanchezQ deleted the cover-traffic-settings-clone-copy branch November 7, 2024 05:40
TakeASwing-420 pushed a commit to TakeASwing-420/nomos-node that referenced this pull request Nov 9, 2024
* Add clone and copy to CoverTrafficSettings

* Make settings fields public.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mixnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants