Make code compile and update open zeppelin dependency #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SNTPlaceholder` uses `MiniMeToken` type in a function even though only `MiniMeBase` is actually imported. This commit fixes the function signature so that the code can actually compile.
|
I'm having trouble making prettier happy. It seems to complain about Ignoring |
Prettier is complaining about it on CI but it doesn't tell what it complains about. It lints perfectly fine locally. For now, ignoring `contracts.json` so we get past the linting stage.
The code couldn't compile because it was using a version of `Ownable2Step` that introduced breaking changes. This commit sets the used version to the latest stable release of OZ, which is 4.9.3. Hence the usages of `Ownable2Step` needed to change as well.
0x-r4bbit
force-pushed
the
fix/minitoken-usage
branch
from
5336a7d to
a07e6e6
Compare
0x-r4bbit
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SNTPlaceholderusesMiniMeTokentype in a function even though onlyMiniMeBaseis actually imported.This commit fixes the function signature so that the code can actually compile.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?