docs: update README with deployment instructions #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
commented
Oct 5, 2023
README.md
Outdated
|
|
||
| To everything work, .env needs to be created out of .env.example. | ||
| You can omit the `--broadcast` option to simulate the deployment before actually performing it. | ||
| `npx hardhat run scripts/deploySNT.js --network <network>` -> deploy to Optimism chain with the `contracts.json` |
There was a problem hiding this comment.
I think this one we can remove no?
There's no hardhat in this repo anymore.
There was a problem hiding this comment.
Yes, hardhat stuff can be removed, or updated to forge equivalents.
There was a problem hiding this comment.
Okay, so for the deploySNT script I've removed the instructions as I don't think this repo needs to deploy SNT.
A deployment script of the OptimismMintableMiniMeToken lives under script now.
I kept the index.js file around for reference. I'm not sure our friends at Certora are actually running deploy scripts for the audit.
3esmit
approved these changes
Oct 5, 2023
README.md
Outdated
|
|
||
| To everything work, .env needs to be created out of .env.example. | ||
| You can omit the `--broadcast` option to simulate the deployment before actually performing it. | ||
| `npx hardhat run scripts/deploySNT.js --network <network>` -> deploy to Optimism chain with the `contracts.json` |
There was a problem hiding this comment.
Yes, hardhat stuff can be removed, or updated to forge equivalents.
0x-r4bbit
force-pushed
the
refactor/rename-placeholder
branch
from
a77dda5 to
54a761b
Compare
Also point to MiniMeToken fork to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also point to MiniMeToken fork to avoid confusion.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?