Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comments, improve claimTokens #21

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix comments, improve claimTokens #21

merged 2 commits into from
Oct 6, 2023

Conversation

3esmit
Copy link
Contributor

@3esmit 3esmit commented Oct 6, 2023

Description

Remove junk comments, improve context of comments & natspec.
Improve claimTokens: use msg.sender instead of owner() in a onlyOwner function; Emit event for extracted ether.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm lint?
  • Ran forge test?

@3esmit 3esmit merged commit b0e2f1b into master Oct 6, 2023
6 checks passed
@3esmit 3esmit deleted the fix-comments branch October 6, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant