refactor(StakeManager): Abstact out codehash verification to better c… #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode reusability chore(StakeManager): move out storage contract and rename it
3esmit
force-pushed
the
abstract-codehash-access
branch
from
509383c to
795e762
Compare
0x-r4bbit
reviewed
Oct 2, 2024
| "certora/helpers/ERC20A.sol" | ||
| ], | ||
| "link" : [ | ||
| "StakeVault:STAKED_TOKEN=ERC20A", | ||
| "StakeManager:stakedToken=ERC20A", | ||
| "StakeManager:stakeRewardEstimate=StakeRewardEstimateA", | ||
| "StakeManager:expiredStakeStorage=ExpiredStakeStorageA", |
There was a problem hiding this comment.
These changes look unrelated to what the commit says it does
0x-r4bbit
reviewed
Oct 2, 2024
| uint256 stakeAmount = 100; | ||
| StakeVault userVault = _createStakingAccount(testUser, stakeAmount, 0, stakeAmount * 10); | ||
| uint256 stakeAmount = 54; | ||
| StakeVault userVault = _createStakingAccount(testUser, stakeAmount, 0, stakeAmount); |
There was a problem hiding this comment.
These changes are also not related to the whitelisting are they?
0x-r4bbit
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode reusability
chore(StakeManager): move out storage contract and rename it
Description
Describe the changes made in your pull request here.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?