Certora rules and migration fixes #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
fix-migration
branch
from
90048dd to
93d88e6
Compare
3esmit
commented
Jan 31, 2024
Comment on lines
+60
to
+80
| modifier noMigration() { | ||
| if (address(migration) != address(0)) { | ||
| revert StakeManager__PendingMigration(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier onlyMigration() { | ||
| if (address(migration) == address(0)) { | ||
| revert StakeManager__NoPendingMigration(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier onlyOldManager() { | ||
| if (msg.sender != address(oldManager)) { | ||
| revert StakeManager__SenderIsNotPreviousStakeManager(); | ||
| } | ||
| _; | ||
| } | ||
|
|
There was a problem hiding this comment.
Implement migration properly
3esmit
commented
Jan 31, 2024
| */ | ||
|
|
||
| function increaseMPFromMigration(uint256 _increasedMP) external onlyOldManager { | ||
| multiplierSupply += _increasedMP; |
There was a problem hiding this comment.
Implement migration properly
5 tasks
0x-r4bbit
force-pushed
the
fix-migration
branch
from
b018574 to
c547be7
Compare
0x-r4bbit
force-pushed
the
fix-migration
branch
from
c547be7 to
59101cd
Compare
This was referenced Feb 12, 2024
|
Friendly ping that this needs to be reviewed (I've cleaned up the commits). Can update the PR once clarified |
5 tasks
0x-r4bbit
force-pushed
the
fix-migration
branch
from
59101cd to
f433dcd
Compare
5 tasks
|
Closing this as this has already landed via #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?pnpm verify?