Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased use of log4j2 readability. #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fbacchella
Copy link
Contributor

Added a log4j2.xml for tests runs.

Added a log4j2.xml for tests runs.

The plugin does not actually uses the log4j2 full power, and that make the code less readable.

@karmi
Copy link

karmi commented Jun 21, 2018

Hi @fbacchella, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@karmi
Copy link

karmi commented Jun 21, 2018

Hi @fbacchella, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@fbacchella
Copy link
Contributor Author

CLA signed.

@fbacchella
Copy link
Contributor Author

It needs PR #330 to work.

Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java changes look great - a nice improvement. If you split out the changes to log4j.xml, I will merge this when the build goes green

src/test/resources/log4j2.xml Outdated Show resolved Hide resolved
Added a log4j2.xml for tests runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants