[DOC]Doc clarifications and additions to url option #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
karenzone
commented
Mar 19, 2020
•
karenzone
commented
- Pull in info captured in Document "headers" as part of the config options #99
- Edits
karenzone
changed the title
karenzone
changed the title
yaauie
reviewed
Mar 27, 2020
There was a problem hiding this comment.
In general, this should be helpful. I've left a couple notes/suggestions, mostly cleaning up derps on my part when I left the original notes on the subject.
I really wish we didn't pass user-config through to manticore without santization, but this is the state that we are in and bubbling this info up to user-facing docs is better than other options.
karenzone
changed the title
Co-Authored-By: Ry Biesemeyer <[email protected]>
… thoroughly tested Co-Authored-By: Ry Biesemeyer <[email protected]>
|
@yaauie Thank you for the comments and clarifications. Please LMKWYT. |
yaauie
requested changes
May 19, 2020
Co-authored-by: Ry Biesemeyer <[email protected]>
yaauie
reviewed
May 20, 2020
There was a problem hiding this comment.
post-merge LGTM on the final edits 👍
Thank you @karenzone for pushing this through
1 task
|
Note to self (@karenzone): Publish pending clean CI |
|
PUBLISHED: Thanks for your help with CI, @jsvd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.