-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for REDIS ZSET #56
base: main
Are you sure you want to change the base?
Conversation
This commit adds support for ZSET queues in REDIS with data_type 'list'. Batch is supported. Score of the message is based on output (see logstash-output-redis). The commit adds the following options to the configuration: * **priority**: *boolean*, default false, enable priority mode * **priority_reverse *boolean*, default false, pop high score items first Usage example: input { redis { host => "127.0.0.1" port => 6379 data_type => "list" key => "syslog" priority => "syslog" priority_reverse => true } }
This pull request is linked to logstash-plugins/logstash-output-redis#46 |
@amaury-d Can you please add some rspec tests for these changes? This is a rather significant update and some tests are absolutely necessary. |
@untergeek Sure, i'll work on it and update the pull request |
@amaury-d any updates here on adding those specs? We'd love to merge this :) |
Hi,
I started working on testing but I didn't have time to finish it until now..
I hope to be able to work on it in week 23 to 26.
…On Fri, Apr 28, 2017 at 5:52 PM, Andrew Cholakian ***@***.***> wrote:
@amaury-d <https://github.com/amaury-d> any updates here on adding those
specs? We'd love to merge this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDuXv8y1gZZ-2EaNlEQ99QNXoBiwCY0ks5r0gtCgaJpZM4L5a1C>
.
--
Amaury Decrême
|
Use the data_type sortedset instead of the priority option
Hi @untergeek @andrewvc , rspec tests and supplementary documentation have been added to pull requests (input and output). |
I really want it to support sortedset data_type. |
Can I resolved the conflicts and merge the code to the master? |
@tandara0 That's fine for me. This PR seems to have been long forgotten and I'm happy if it can be useful to someone else. Therefore, I'm not sure how you can work on this PR on github. |
Thanks. I will try. |
This commit adds support for ZSET queues in REDIS with data_type
sortedset
.Batch is supported.
Score of the message is based on output (see logstash-output-redis).
The pull request adds the following option to the configuration:
first
Usage example:
=> Il will pop from the sortedset with the key
syslog
the messages with the higher scores firstThanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/