-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to send syslog RFC5424 structured_data #1
base: main
Are you sure you want to change the base?
Conversation
@jordansissel - could you give me some pointers on what I need to do to get this PR ready for merging? Thanks! |
Hi as you mentioned we can get some value in structure data by using: syslog { In which file we need to add this? |
Just add the extra data you want to the ie, if you wanted to add some extra data about the environment you are sending data from:
|
Thanks a lot for your contribution @mrdavidlaing, in order to move forward with your PR is going to be necessary to sign the CLA agreement, you can find more information at https://www.elastic.co/contributor-agreement. On the other side, it would be super nice if you can add test for this change. We try to enforce that all PR introduce some kind of testing, so we're able to increase the overall quality. Don't hesitate to ask any question regarding you might have, more than looking forward to help. Looking forward to get this in, /cheers |
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
👍 Would love to have this! |
Hi @mrdavidlaing |
It seems this PR is abandoned, so I created a new one for this feature #67. |
Currently the syslog output always sets the syslog RFC5424 structured data field to
-
.The PR adds the ability to send customised syslog RFC5424 structured data for the syslog output.
This is really helpful if you want to pass additional "meta data" along with your syslog message.
ie.
will result in syslog messages that look this this:
Omitting the structured_data config
Keeps the existing behaviour of sending
-