Preventing NPE after (de)serialization of a LoggingEvent #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoggingEvent after it has been serialized and de-serialized (happens when using a SocketAppender)
|
Hello Can you please accept this PR ? Thanks |
|
Hello, Thanks! |
pyr
approved these changes
Jan 10, 2019
|
LGTM, can I ask for a rebase to a single commit? Cheers, |
|
Dusting off the 🕸 after 4 years 😁. You could do a squash when merging. Otherwise I can remove commit a323bb5 about ignoring files. I'd rather not combine it with the other commit as it is something different. Let me know. |
|
Hello @rlindooren @pyr , Naive question : Once you release the 1.8 with this change, will it be available on Maven automatically? Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making use of a SocketAppender logging events are serialized and de-serialized. Because the throwable field on ThrowableInformation is transient it will not be available for further processing after de-serialization. Causing a NullPointerException.
My change checks if the throwable field is not null before trying to use it.