Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: specify in.logs.betterstack.com ingesting host #135

Merged
merged 6 commits into from
Feb 25, 2025
Merged

E2E tests: specify in.logs.betterstack.com ingesting host #135

merged 6 commits into from
Feb 25, 2025

Conversation

PetrHeinz
Copy link
Member

@PetrHeinz PetrHeinz commented Feb 25, 2025 •
edited
Loading

Fixes E2E tests after changes in #133, prefixes the ingesting host with https:// before using it as endpoint

Before it was necessary to run node index.js <source-token> https://<ingesting-host>

@PetrHeinz PetrHeinz marked this pull request as ready for review February 25, 2025 17:30
@PetrHeinz PetrHeinz requested a review from gyfis February 25, 2025 17:30
gyfis
gyfis approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@gyfis gyfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PetrHeinz PetrHeinz merged commit c730876 into master Feb 25, 2025
28 checks passed
@PetrHeinz PetrHeinz deleted the ph/e2e-fix branch February 25, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyfis gyfis gyfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PetrHeinz @gyfis