DEV-44293 - Support Logz Datasource #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added required changes in elasticsearch and prometheus clients to add logz headers so we can call logz datasources * Refactored implementation in logz alert evaluation so we only pass headers because url change is no longer required * Added fix to alert evaluation to check if rule routine exists instead of getOrCreate which caused routines not to be created via scheduler if eval called before scheduler updates registry. * added to custom.ini required configs for logz alert evaluation to work
ohadza
reviewed
May 19, 2024
|
run-test |
* Added relevant header for m3 query ervice endpoints on prometheus client * Added on elasticsearch the relevant queryParams for querySource
|
run-test |
|
run-test |
|
run-test |
2 similar comments
|
run-test |
|
run-test |
|
run-test |
Fix for prometheus_test.go to work with changes Logz comments in missing places
|
run-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Support the Logz.io query datasources by adding necessary additions into the elasticsearch and prometheus calls and throughout the system.
Changes were added on the entry points of the different query APIs, to pass the headers of the requests, and in the client side, where the requests to the datasource is being sent.
Why do we need this feature?
To be able to query datasources that are managed in logzio we need to pass relevant headers and params so the query services APIs will accept the calls.
** PR Changes **:
Special notes for your reviewer:
Please check that: