DEV-46341: add logzio opsgenie support #40
Conversation
Jonathan-Eng
changed the title
|
run-test |
1 similar comment
|
run-test |
…ot supported by logzio integration
…explanation of logzio opsgenie receiver in ui
Jonathan-Eng
force-pushed
the
DEV-46341-create-logzio-opsgenine-notification-endpoint-option
branch
from
5e4261a to
0cf061a
Compare
There was a problem hiding this comment.
the same comment as other PR about adding the logz grafana change comment with reference to ticket
also, i'm not sure why but i don't see the grafana jenkins pipeline ran .
I want us to make sure no new tests are failing, and fix them if there are.
(to see the previous failing you can take a look at the last run in the main branch. i hope it is still available)
| @@ -147,7 +146,7 @@ export function ChannelSubForm<R extends ChannelValues>({ | |||
| inputId={contactPointTypeInputId} | |||
| {...field} | |||
| width={37} | |||
| options={typeOptions.filter((o) => !o.value.startsWith(INTERNAL_CHANNEL_TYPE_PREFIX))} // LOGZ.IO GRAFANA CHANGE :: DEV-35483 - Filter out logzio opsgenie type from creation | |||
| options={typeOptions} | |||
There was a problem hiding this comment.
why remove this ? 🤔 don't we want same behaviour as before?
There was a problem hiding this comment.
no, we want to support v1. decision was made by @ohadza and Amos
| @@ -519,6 +519,6 @@ replace xorm.io/xorm => ./pkg/util/xorm | |||
| // This is required in order to get notification delivery errors from the receivers API. | |||
| replace github.com/prometheus/alertmanager => github.com/grafana/prometheus-alertmanager v0.25.1-0.20240208102907-e82436ce63e6 | |||
|
|
|||
| replace github.com/grafana/alerting => github.com/logzio/data-viz-alerting v0.0.0-20240709132848-5bf841d2c3d3 | |||
There was a problem hiding this comment.
just to make sure - i guess once you are merging the change in grafana-alerting , you'll also need to update the commit here (and on the go.sum) ?
otherwise you'd be referring to the branch and not "master" version 🤔
There was a problem hiding this comment.
yes, there will be another commit. you are right
|
run-test |
| @@ -1339,6 +1339,35 @@ func GetAvailableNotifiers() []*NotifierPlugin { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| Type: "logzio_opsgenie", | |||
| Name: "LogzioOpsGenie", | |||
There was a problem hiding this comment.
Is this name agreeable? Hope it doesn't require refactor if not. @yasmin-tr @ohadza
There was a problem hiding this comment.
this is customer facing
There was a problem hiding this comment.
btw - the "logzio_opsgenie" type today as well appears on the api , so customers will see that anyway.
if it is correct to call it then maybe it's ok. i guess we just need to make sure it looks ok on the UI as "LogzioOpsGenie" (maybe it needs to be with space? or some icon even? 🤷♀️ )
i'd verify with Amos (product)
|
run-test |
add support for logzio opsgenie integration (v1 variant)