DEV-47346-extract-grafana-evaluation-into-goroutine #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run-test |
1 similar comment
|
run-test |
|
run-test |
ohadza
reviewed
Nov 26, 2024
| } else { | ||
| evaluationsErrors = append(evaluationsErrors, apimodels.AlertEvalRunResult{UID: evalRequest.AlertRule.UID, EvalTime: evalRequest.EvalTime, RunResult: "success"}) | ||
| } | ||
| go func(ctx context.Context, request ngmodels.ExternalAlertEvaluationRequest) { |
There was a problem hiding this comment.
I think we should take into consideration the way Garafana did it with thetime.AfterFunc(time.Duration(int64(i)*step), func()
the step is: step = sch.baseInterval.Nanoseconds() / int64(len(readyToRun))
what is basically do is to spread the load on the query engine in the duration of the tick (but we can do it half tick)
this was an issue in the past in the data hub - but I didn't encounter it in the alerts - WDYT?
There was a problem hiding this comment.
Thats a good point. why do we want to do it half of the tick? It will make things tight only in the first 30 seconds of the minute
|
run-test |
1 similar comment
|
run-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana evaluations extracted to goroutines to enable skipping of the slow alerts and reduce API response time